BUG: Report error if --python-script associated with non-existent file#1018
Open
jcfr wants to merge 1 commit intoSlicer:masterfrom
Open
BUG: Report error if --python-script associated with non-existent file#1018jcfr wants to merge 1 commit intoSlicer:masterfrom
jcfr wants to merge 1 commit intoSlicer:masterfrom
Conversation
This commit ensures an exception is raised when the python script does not exist. When associated with the --exit-after-startup option, a non-zero status code is now returned when Slicer exit.
Member
Author
lassoan
reviewed
Sep 7, 2018
Contributor
lassoan
left a comment
lassoan
left a comment
There was a problem hiding this comment.
Would it be possible to throw the error from inside this->corePythonManager()->executeFile()?
Execution can go wrong in many ways and it is odd that one particular error is reported with an external mechanism.
At least we should let executeFile decide if there is an error (file does not exist, not readable, etc) instead of just checking outside if the file exists. This would be also more robust, when script is defined by relative path (executeFile might be able to find it, while QFile::exists cannot).
Member
Author
|
Thanks for the review
Definitively, that makes sense. For reference: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit ensures an exception is raised when the python script does not
exist. When associated with the --exit-after-startup option, a non-zero status
code is now returned when Slicer exit.